Add Sylius template event#11534
Merged
Merged
Conversation
pamil
approved these changes
Jun 1, 2020
Contributor
Author
|
Can this be merged? |
Contributor
|
Hey @tavy315, thanks a lot for your contribution and your patience. It can be merged to the master, however we have a red build there. Once it is fixed I will ping you back |
Contributor
Author
|
Ok, no problem. Not sure if I can help there. |
Contributor
|
My mistake should be merged to 1.7 |
Contributor
|
Hey Octav, could you rebase your work to branch 1.7? |
Contributor
Author
|
@lchrusciel, sorry, I think I merged it instead. I'm still not used to sync and rebase a fork. |
Contributor
|
Thank you, Octav! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen the changes done in (186c13c), but I guess that this file was missed.