Add slick-carousel to ShopBundle entry.js#11633
Merged
Merged
Conversation
Commit f3e5661 added slick-carousel/slick/slick.css to src/Sylius/Bundle/ShopBundle/gulpfile.babel.js, if you want to use webpack encore, you should add slick-carousel/slick/slick.css to entry.js too
Contributor
|
@MatthieuCutin Do you mind if I cherry-pick your commit? So we have only one PR. |
Contributor
|
@jacquesbh I will merge this PR and then rebase your to 1.7 |
Contributor
|
Thank you, @MatthieuCutin! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f3e5661 added slick-carousel/slick/slick.css to src/Sylius/Bundle/ShopBundle/gulpfile.babel.js
If you want to use webpack encore, you should add slick-carousel/slick/slick.css to entry.js too
Related to #11631