Fix bug in order total shipping rules#11761
Merged
Merged
Conversation
Contributor
|
Hello @loevgaard, yesterday we changed branches on Sylius, and old |
d77f16a to
071d4b7
Compare
Contributor
Author
|
@AdamKasp: Not sure I did it right. Can you confirm? |
stloyd
reviewed
Aug 25, 2020
AdamKasp
reviewed
Aug 25, 2020
GSadee
reviewed
Aug 25, 2020
Member
GSadee
left a comment
There was a problem hiding this comment.
Could you adjust OrderTotalGreaterThanOrEqualRuleCheckerSpec to this fix?
GSadee
approved these changes
Aug 25, 2020
Member
|
Thanks, Joachim! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shipping method rules for order totals wasn't working because of this bug.