Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Disable province code change in PUT endpoint#11807

Merged
GSadee merged 4 commits into
Sylius:1.8from
arti0090:api-fix-province-put-endpoint
Sep 9, 2020
Merged

[API] Disable province code change in PUT endpoint#11807
GSadee merged 4 commits into
Sylius:1.8from
arti0090:api-fix-province-put-endpoint

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

@arti0090 arti0090 commented Sep 4, 2020

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? not sure
Deprecations? not sure
License MIT

@arti0090 arti0090 requested a review from a team as a code owner September 4, 2020 07:26
@GSadee GSadee added the API APIs related issues and PRs. label Sep 4, 2020
@arti0090 arti0090 force-pushed the api-fix-province-put-endpoint branch from 7b4a726 to 6899557 Compare September 6, 2020 08:32
@arti0090 arti0090 changed the title [WIP][API] Disable province code change in PUT endpoint [API] Disable province code change in PUT endpoint Sep 6, 2020
Comment thread src/Sylius/Behat/Context/Api/Admin/ManagingCountriesContext.php Outdated
Copy link
Copy Markdown
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you should rebase with 1.8 to fix failing build

Comment thread src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Province.xml Outdated
@arti0090 arti0090 force-pushed the api-fix-province-put-endpoint branch 3 times, most recently from da7f49b to 6af6ce5 Compare September 8, 2020 12:08
@arti0090 arti0090 force-pushed the api-fix-province-put-endpoint branch from 6af6ce5 to 6afcd05 Compare September 9, 2020 09:13
@GSadee GSadee merged commit 29a9fbb into Sylius:1.8 Sep 9, 2020
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Sep 9, 2020

Thank you, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants