Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use DQL instead of repository to fetch product attributes#11882

Merged
lchrusciel merged 2 commits into
Sylius:1.8from
loevgaard:11843-fix-migration
Oct 5, 2020
Merged

Use DQL instead of repository to fetch product attributes#11882
lchrusciel merged 2 commits into
Sylius:1.8from
loevgaard:11843-fix-migration

Conversation

@loevgaard
Copy link
Copy Markdown
Contributor

@loevgaard loevgaard commented Sep 28, 2020

Q A
Branch? 1.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11843
License MIT

@loevgaard loevgaard requested a review from a team as a code owner September 28, 2020 11:59
@loevgaard
Copy link
Copy Markdown
Contributor Author

loevgaard commented Sep 28, 2020

I have no idea why the build fails, but since it doesn't fail on PHP7.3 I guess it doesn't have something to do with this PR?

lchrusciel
lchrusciel approved these changes Sep 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Joachim,

thanks for your contribution. Does it solve the issue with changes to entities mapping during migration? I was wondering if we shouldn't go even further and write plain SQL to fetch all the required attributes. What do you think?

Also, I've restarted your build. The error seems to be not related with your changes.

@loevgaard
Copy link
Copy Markdown
Contributor Author

loevgaard commented Sep 28, 2020

I used https://patch-diff.githubusercontent.com/raw/Sylius/Sylius/pull/11882.patch as a patch for the issue mentioned and it fixes that issue, yes. I don't see why we would need to rewrite it to SQL.

@lchrusciel lchrusciel changed the base branch from master to 1.7 September 28, 2020 19:07
@lchrusciel lchrusciel changed the base branch from 1.7 to 1.8 September 28, 2020 19:07
@lchrusciel lchrusciel changed the base branch from 1.8 to master September 28, 2020 19:07
@lchrusciel lchrusciel added Bug Confirmed bugs or bugfixes. Environment Environment (OS, databases, libraries, etc.) specific issues. labels Sep 28, 2020
@lchrusciel lchrusciel changed the base branch from master to 1.8 September 28, 2020 19:10
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Sep 28, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "11843-fix-migration" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel changed the base branch from 1.8 to master September 29, 2020 20:16
@lchrusciel lchrusciel changed the base branch from master to 1.8 September 29, 2020 20:19
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Sep 29, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "11843-fix-migration" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit 722f2ae into Sylius:1.8 Oct 5, 2020
@lchrusciel
Copy link
Copy Markdown
Contributor

lchrusciel commented Oct 5, 2020

Thanks, Joachim! 🥇

@loevgaard loevgaard deleted the 11843-fix-migration branch October 5, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes. Environment Environment (OS, databases, libraries, etc.) specific issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to extend ProductAttribute with new properties after 1.8

2 participants

@loevgaard @lchrusciel