[API][Product] Change identifier for shop endpoint from slug to code#12034
Merged
lchrusciel merged 1 commit intoNov 13, 2020
Merged
Conversation
Member
GSadee
commented
Nov 12, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on #11925 |
| License | MIT |
cc52ef5 to
9fd92fc
Compare
AdamKasp
approved these changes
Nov 12, 2020
9fd92fc to
e3c5bc2
Compare
lchrusciel
approved these changes
Nov 12, 2020
e3c5bc2 to
13c2fa3
Compare
13c2fa3 to
58ce6bd
Compare
lchrusciel
approved these changes
Nov 13, 2020
Contributor
|
Thank you, Grzegorz! 🥇 |
lchrusciel
reviewed
Nov 13, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
@GSadee but we should mention it in the UPGRADE file, I assume.
Tomanhez
added a commit
that referenced
this pull request
Nov 13, 2020
…dentifier for shop endpoint (GSadee) This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #12034 | License | MIT Commits ------- 1c29fcf [API][Product] Add note in UPGRADE file about changing identifier for shop endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.