[API] Add missing endpoints for address and country resources#12045
Merged
Conversation
Member
GSadee
commented
Nov 13, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | after #11925 |
| License | MIT |
Tomanhez
approved these changes
Nov 13, 2020
arti0090
approved these changes
Nov 14, 2020
lchrusciel
reviewed
Nov 14, 2020
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
How did we miss it? Shouldn't we have new endpoints covered by tests as well?
Member
Author
|
@lchrusciel these endpoints were not needed in the given contexts so far, but now I have added them to resolve the proper iris in responses |
AdamKasp
approved these changes
Nov 16, 2020
Contributor
|
Thanks, Grzegorz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.