Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Behat]refactor of setup/PromotionContext class#12075

Merged
GSadee merged 1 commit into
Sylius:masterfrom
arti0090:refactor-promotion-context
Nov 23, 2020
Merged

[Behat]refactor of setup/PromotionContext class#12075
GSadee merged 1 commit into
Sylius:masterfrom
arti0090:refactor-promotion-context

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
License MIT

Done: add missing return types, add missing variable type, minor improvements

@arti0090 arti0090 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 21, 2020
@arti0090 arti0090 requested a review from a team as a code owner November 21, 2020 17:34
@arti0090 arti0090 changed the title refactor of setup/PromotionContext class [Behat]refactor of setup/PromotionContext class Nov 21, 2020
@arti0090 arti0090 added the Behat Issues and PRs aimed at improving Behat usage. label Nov 21, 2020
@arti0090 arti0090 force-pushed the refactor-promotion-context branch from 90f4e05 to 4f2ba20 Compare November 21, 2020 18:24
@GSadee GSadee merged commit 518b03b into Sylius:master Nov 23, 2020
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Nov 23, 2020

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Behat Issues and PRs aimed at improving Behat usage. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants