Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use sha512 to encode passwords in test environments#12093

Merged
Zales0123 merged 1 commit into
Sylius:1.8from
pamil:1.8-sha512-test
Nov 30, 2020
Merged

Use sha512 to encode passwords in test environments#12093
Zales0123 merged 1 commit into
Sylius:1.8from
pamil:1.8-sha512-test

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Nov 26, 2020

See #11599. Hashing passwords with argon2i takes 60% of PHPUnit's execution time.
CleanShot 2020-11-26 at 16 03 51@2x

@pamil pamil requested a review from a team as a code owner November 26, 2020 15:01
@pamil pamil added Maintenance CI configurations, READMEs, releases, etc. Performance labels Nov 26, 2020
@Zales0123 Zales0123 merged commit 856bf80 into Sylius:1.8 Nov 30, 2020
@Zales0123
Copy link
Copy Markdown
Contributor

Thank you, Kamil! 🎉

@pamil pamil deleted the 1.8-sha512-test branch November 30, 2020 11:11
@Kocal
Copy link
Copy Markdown

Kocal commented Dec 16, 2020

Why not using plaintext as encoder? That would be faster no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc. Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants