[Api] Locale code on checkout#12139
Merged
Merged
Conversation
Contributor
Tomanhez
commented
Dec 8, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
approved these changes
Dec 9, 2020
AdamKasp
approved these changes
Dec 9, 2020
271fff1 to
d9e5d66
Compare
lchrusciel
reviewed
Dec 9, 2020
d9dca96 to
1e0f8ad
Compare
lchrusciel
reviewed
Dec 10, 2020
| <group>shop:order:account:read</group> | ||
| <group>checkout:read</group> | ||
| <group>cart:update</group> | ||
| <group>order:read</group> |
Contributor
There was a problem hiding this comment.
As you are touching this area, can we introduce shop: prefix to order read serialization? Can be done in separate PR
Contributor
Author
There was a problem hiding this comment.
Ok I do it in new PR after merge this
Contributor
|
Rebase needed |
GSadee
reviewed
Dec 11, 2020
1e0f8ad to
ce46eeb
Compare
364322f to
dc4fe4d
Compare
arti0090
approved these changes
Dec 14, 2020
lchrusciel
approved these changes
Dec 14, 2020
AdamKasp
reviewed
Dec 15, 2020
c3f1eff to
78f3415
Compare
lchrusciel
reviewed
Dec 15, 2020
78f3415 to
1a9a681
Compare
lchrusciel
approved these changes
Dec 16, 2020
Contributor
|
Thanks, Tomasz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.