Add tag no-api to scenario#12161
Merged
Merged
Conversation
Contributor
arti0090
commented
Dec 14, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
Tomanhez
approved these changes
Dec 14, 2020
GSadee
reviewed
Dec 14, 2020
| And I am a logged in customer | ||
|
|
||
| @ui @api | ||
| @ui @no-api |
Member
There was a problem hiding this comment.
Maybe we should consider adding this tag also for other scenarios from this file?
Contributor
There was a problem hiding this comment.
If we decided to revert this logic: #12153 then lets revert it with this part as well: https://github.com/Sylius/Sylius/pull/12153/files#diff-d5707a6baca117e8c5e52ea5057c00ab5521dc180c2177fe73c5779ec63a666cR284-R294
Extracting to separate method can stay
AdamKasp
approved these changes
Dec 15, 2020
Contributor
|
Thank you, @arti0090! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.