update upgrade file after changes with tax adjustment#12164
Merged
Conversation
Contributor
arti0090
commented
Dec 16, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no/yes |
| Related tickets | This PR is related to failing build from sylius/standard Sylius/Sylius-Standard#459 and also #12116 |
| License | MIT |
AdamKasp
reviewed
Dec 16, 2020
| bin/console doctrine:migrations:version 'CoreBundle/Migrations/Version20201208105207' --add | ||
| ``` | ||
|
|
||
| 1. The base of `Adjustment` class has changed. If you extend your adjustments already(or have them overridden by default, because of Sylius-Standard usage), you should base your Adjustment class on `AdjustmentFQCN` |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. The base of `Adjustment` class has changed. If you extend your adjustments already(or have them overridden by default, because of Sylius-Standard usage), you should base your Adjustment class on `AdjustmentFQCN` | |
| 1. The base of `Adjustment` class has changed. If you extend your adjustments already(or have them overridden by default, because of Sylius-Standard usage), you should base your Adjustment class on `Adjustment` FQCN |
?
Contributor
There was a problem hiding this comment.
Suggested change
| 1. The base of `Adjustment` class has changed. If you extend your adjustments already(or have them overridden by default, because of Sylius-Standard usage), you should base your Adjustment class on `AdjustmentFQCN` | |
| 1. The base of the `Adjustment` class has changed. If you extend your adjustments already(or have them overridden by default, because of Sylius-Standard usage), you should base your Adjustment class on `Sylius\Component\Core\Model\Adjustment` instead of `Sylius\Component\Order\Model\Adjustment`. |
FQCN(full qualified class name) I used as a short cut, as I was too lazy to copy the whole class name in our conversation :P
Contributor
Author
There was a problem hiding this comment.
It is so sad for me (because of last comment) to resolve this conversation, that I won't do it 😂
Tomanhez
approved these changes
Dec 16, 2020
lchrusciel
approved these changes
Dec 17, 2020
Contributor
|
Thanks, @arti0090! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.