Feat: Add breadcrumb var in CRUD template for AdminBundle#12202
Conversation
|
Hi @toofff! I believe such a customization option is already introduced a level higher in this file. It, of course, is a little bit different - but the proposed solution seems as duplicated behaviour. |
|
@Zales0123 I'm not thinking duplicating an existing solution. Currently we can directly change the However for the |
|
@Zales0123 do I have to keep the branch up to date or do I just delete my pull request? |
|
Hello, sorry for processing it long 🖖 Please, update to the master branch and I would like to see the opinion of other @Sylius/core-team members :) |
|
@Zales0123 Done ;) |
lchrusciel
left a comment
There was a problem hiding this comment.
A small improvement, but I would vote for adding it.
A small problem that I have, is that we don't know how to test it and ensure, that it is working in the future. Probably it is true for the rest of these dynamic fields.
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
|
@Zales0123 @lchrusciel are we closing my pull request or do you want to merge it? What do you need to merge it? |
|
Thanks, @toofff! 🎉 |
|
I was a long-lived PR, but lets put it to the master :) If I'm correct, we do not have any docs about this feature. May you propose something and contribute to docs? |
|
@lchrusciel As soon as I have some time I will add this in the documentation |
Uh oh!
There was an error while loading. Please reload this page.