Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG-FIX] [Checkout] Change email addressing step#12210

Merged
lchrusciel merged 3 commits into
Sylius:1.8from
SirDomin:change-email-addressing-step
Jan 8, 2021
Merged

[BUG-FIX] [Checkout] Change email addressing step#12210
lchrusciel merged 3 commits into
Sylius:1.8from
SirDomin:change-email-addressing-step

Conversation

@SirDomin
Copy link
Copy Markdown
Contributor

@SirDomin SirDomin commented Dec 30, 2020

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? not sure
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner December 30, 2020 14:34
@probot-autolabeler probot-autolabeler Bot added Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Dec 30, 2020
@SirDomin SirDomin changed the base branch from 1.8 to master December 30, 2020 14:37
@SirDomin SirDomin added Bug Confirmed bugs or bugfixes. UX Issues and PRs aimed at improving User eXperience. labels Dec 30, 2020
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
@SirDomin SirDomin force-pushed the change-email-addressing-step branch from 38c6197 to 3a1ceed Compare December 30, 2020 15:51
@probot-autolabeler probot-autolabeler Bot added the Shop ShopBundle related issues and PRs. label Dec 30, 2020
@SirDomin SirDomin changed the base branch from master to 1.8 December 30, 2020 15:51
@SirDomin SirDomin force-pushed the change-email-addressing-step branch 2 times, most recently from f33ff4e to f81af48 Compare December 30, 2020 18:11
@SirDomin SirDomin force-pushed the change-email-addressing-step branch from f81af48 to 14b870c Compare December 30, 2020 18:43
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature Outdated
Comment thread features/checkout/ability_to_change_email_during_checkout.feature
Comment thread src/Sylius/Behat/Context/Ui/Shop/CheckoutContext.php Outdated
@@ -0,0 +1,28 @@
@checkout
Feature: Changing email during checkout with registered email
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we synchronize the name of the file with the feature name

@@ -0,0 +1,28 @@
@checkout
Feature: Changing email during checkout with registered email
In order to change email during checkout
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to change email during checkout
In order to always check out with the relevant email address

Feature: Changing email during checkout with registered email
In order to change email during checkout
As a Customer
I want to see email input field when im not logged in
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
I want to see email input field when im not logged in
I want to be able to change email if I'm not logged in

@lchrusciel lchrusciel merged commit cc31c41 into Sylius:1.8 Jan 8, 2021
@lchrusciel
Copy link
Copy Markdown
Contributor

Thank you, @SirDomin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants