Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Search products by name within specific taxon#12287

Merged
GSadee merged 1 commit into
Sylius:masterfrom
pamil:api-search-products-by-name
Jan 29, 2021
Merged

[API] Search products by name within specific taxon#12287
GSadee merged 1 commit into
Sylius:masterfrom
pamil:api-search-products-by-name

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Jan 28, 2021

No description provided.

@pamil pamil requested a review from a team as a code owner January 28, 2021 16:11
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Jan 28, 2021
/** @param string|int $value */
public function addFilter(string $key, $value): void;

/** @param string|int $value */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @param string|int $value */

$this->addParameter($key, $value);
}

/** @param string|int $value */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @param string|int $value */

/**
* @When I search for products with name :name
*/
public function iSearchForProductsWithName(string $name)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return type

@GSadee GSadee merged commit 4b34834 into Sylius:master Jan 29, 2021
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Jan 29, 2021

Thank you, Kamil! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants