Filter product variants by product & option values#12382
Merged
pamil merged 4 commits intoMar 5, 2021
Merged
Conversation
e6b4f5a to
a6c5d18
Compare
AdamKasp
reviewed
Mar 4, 2021
AdamKasp
reviewed
Mar 4, 2021
GSadee
reviewed
Mar 5, 2021
AdamKasp
reviewed
Mar 5, 2021
dfce9b9 to
32f74a7
Compare
32f74a7 to
9073bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
/api/v2/shop/product-variants?product=%2Fapi%2Fv2%2Fshop%2Fproducts%2FLoose_white_designer_T_Shirt) - my idea is thatChannelContextBuilderis only run for the "main" API request, normalizing product's IRI and going through this data provider does not trigger context builder beforehand?optionValues=/option/value/iri