Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Decouple translation used in emails from shopBundle to coreBundle#12405

Merged
lchrusciel merged 1 commit into
Sylius:masterfrom
arti0090:decouple-email-translations
Mar 5, 2021
Merged

Decouple translation used in emails from shopBundle to coreBundle#12405
lchrusciel merged 1 commit into
Sylius:masterfrom
arti0090:decouple-email-translations

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

@arti0090 arti0090 commented Mar 2, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@arti0090 arti0090 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). API APIs related issues and PRs. labels Mar 2, 2021
@arti0090 arti0090 requested a review from a team as a code owner March 2, 2021 12:53
@arti0090 arti0090 force-pushed the decouple-email-translations branch from ee63630 to 23086f1 Compare March 4, 2021 07:22
Copy link
Copy Markdown
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It highly relies on the bundle loading order though.

@lchrusciel lchrusciel merged commit 6bbd6ed into Sylius:master Mar 5, 2021
@lchrusciel
Copy link
Copy Markdown
Contributor

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants