[AttributeBundle] custom locale_code fixed#12407
Merged
Merged
Conversation
…roen, pamil)
This PR was merged into the 1.8 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.8
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
This fixes a bug where this following taxon tree:
* A
* B
* C
would lead to a full name of `A / B > C` instead of `A > B > C` if the call was `$taxonC->getFullname('>');`
Commits
-------
7d72050 Pass path delimiter up to parent
f141354 Fix test case for default and custom taxon path delimiter
3bde33a Add tests for path delimiter while getting taxon's fullname
…lues (christopherhero) This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT In the js file, `src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-auto-complete.js` is set timeout = 5 sec to wait for an async response from ajax autocomplete action. possibly this was added because someone calculated that this time would be enough to load mutation observers. However, when we add more than one field of type `ResourceAutocompleteChoiceType` it loads with a long delay. In this PR I removed timeout and add the `refresh` action on the dropdown with 'set selected' action after the response receiving. Commits ------- 2a4cc02 Removing hard timeout on edit while load selected values
Contributor
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
3b1b3be to
515df38
Compare
Contributor
|
Thanks, @Mateuszry! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we pass custom
locale_codeinSelectAttributeTypeconfigurationdefaultLocaleCodehas always been used, because there was an error in the condition (optionsinstead ofchoice).