Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FOSOAuthServerBundle] Remove incompatible version#12427

Merged
pamil merged 1 commit into
Sylius:1.9from
Prometee:patch-1
Mar 16, 2021
Merged

[FOSOAuthServerBundle] Remove incompatible version#12427
pamil merged 1 commit into
Sylius:1.9from
Prometee:patch-1

Conversation

@Prometee
Copy link
Copy Markdown
Contributor

@Prometee Prometee commented Mar 8, 2021

Q A
Branch? 1.9 only
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

If you try to install Sylius ~1.9.0 with Symfony ^4.4 you will get this type of error :

[TypeError]                                                                                                                                                                                                                          
  Argument 1 passed to FOS\OAuthServerBundle\Entity\ClientManager::__construct() must be an instance of Doctrine\Common\Persistence\ObjectManager, instance of EntityManager_9a5be93 given, called in var/cache/test/ContainerXDiFD64/getSylius_OauthServer_ClientManagerService.php on line 14

This error occurred because all deprecated Doctrine Persistence API have been replaced in Sylius 1.9 making FOSOAuthServerBundle ^1.6 incompatible with Sylius ~1.9.0

@Prometee Prometee requested a review from a team as a code owner March 8, 2021 16:32
@Prometee Prometee mentioned this pull request Mar 8, 2021
Closed
vvasiloi added a commit to vvasiloi/supplier-plugin that referenced this pull request Mar 10, 2021
@vvasiloi
fix dependencies/config issues addressed in Sylius/Sylius#12427 and S…
e85d43e 
…ylius/PluginSkeleton#255
@pamil pamil added the Bug Confirmed bugs or bugfixes. label Mar 16, 2021
@pamil pamil merged commit 908c352 into Sylius:1.9 Mar 16, 2021
@pamil
Copy link
Copy Markdown
Contributor

pamil commented Mar 16, 2021

Thank you, Francis! 🥇

@Prometee Prometee deleted the patch-1 branch March 16, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pamil pamil pamil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Prometee @pamil