Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change command constructor#12480

Merged
GSadee merged 2 commits into
Sylius:masterfrom
arti0090:add-note-to-upgrade-file
Mar 25, 2021
Merged

Change command constructor#12480
GSadee merged 2 commits into
Sylius:masterfrom
arti0090:add-note-to-upgrade-file

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets completes #12476
License MIT

@arti0090 arti0090 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Mar 24, 2021
@arti0090 arti0090 requested a review from a team as a code owner March 24, 2021 15:27
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Mar 24, 2021
Comment thread UPGRADE-1.10.md Outdated
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Mar 25, 2021
@arti0090 arti0090 changed the title Add note in upgrade file about changed command constructor Change command constructor Mar 25, 2021
@arti0090 arti0090 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). and removed Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Mar 25, 2021
MessageBusInterface $commandBus
): void {
$command = new RegisterShopUser('Will', 'Smith', '[email protected]', 'iamrobot', true, '+13104322400');
$command = new RegisterShopUser('Will', 'Smith', '[email protected]', 'iamrobot','+13104322400',true);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$command = new RegisterShopUser('Will', 'Smith', '[email protected]', 'iamrobot','+13104322400',true);
$command = new RegisterShopUser('Will', 'Smith', '[email protected]', 'iamrobot','+13104322400', true);

@GSadee GSadee merged commit 9be7f5e into Sylius:master Mar 25, 2021
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Mar 25, 2021

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants