[API] sorting product by position in taxon#12621
Merged
GSadee merged 2 commits intoMay 12, 2021
Merged
Conversation
Contributor
AdamKasp
commented
May 10, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| License | MIT |
lchrusciel
reviewed
May 10, 2021
|
|
||
| $rootAlias = $queryBuilder->getRootAliases()[0]; | ||
| $queryBuilder | ||
| ->distinct() |
Contributor
There was a problem hiding this comment.
Why have you decided for distinct here?
Contributor
Author
There was a problem hiding this comment.
Because I added innerJoin to products taxons collection, and I want to avoid any duplication of record in response.
1023d2d to
957ebb7
Compare
GSadee
reviewed
May 11, 2021
957ebb7 to
8ef2574
Compare
c27bb21 to
45a61db
Compare
GSadee
approved these changes
May 12, 2021
Member
|
Thank you, Adam! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.