Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Admin] Fix shipping totals in order summary#12875

Merged
lchrusciel merged 1 commit into
Sylius:1.9from
fixeditforyou:fix/order-summary-shipping-totals
Aug 17, 2021
Merged

[Admin] Fix shipping totals in order summary#12875
lchrusciel merged 1 commit into
Sylius:1.9from
fixeditforyou:fix/order-summary-shipping-totals

Conversation

@aleho
Copy link
Copy Markdown
Contributor

@aleho aleho commented Aug 10, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

The extra wrapping div breaks Semantic UI's list here.

before

I'm guessing the intended layout was this?
after

@aleho aleho requested a review from a team as a code owner August 10, 2021 08:55
@probot-autolabeler probot-autolabeler Bot added the Admin AdminBundle related issues and PRs. label Aug 10, 2021
Copy link
Copy Markdown
Contributor

@Arminek Arminek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Thank you @aleho

@lchrusciel lchrusciel merged commit 3069c1f into Sylius:1.9 Aug 17, 2021
@lchrusciel
Copy link
Copy Markdown
Contributor

Thank you, Alexander! 🥇

@aleho aleho deleted the fix/order-summary-shipping-totals branch November 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin AdminBundle related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants