[Documentation] Note about changes related to upgrade to GridBundle 1.10#12881
Merged
lchrusciel merged 2 commits intoAug 18, 2021
Conversation
Arminek
approved these changes
Aug 12, 2021
Contributor
|
Now that I see this I think the checklist should've also contained 'add global parameters that apply to all grids'. |
Contributor
|
Oh, wait... there were global params, but you removed them... never mind. |
Contributor
Author
|
@vvasiloi yes I removed them because we decided to have by default |
3a88f1f to
f579ca9
Compare
Member
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
f579ca9 to
e489775
Compare
lchrusciel
reviewed
Aug 18, 2021
faa5cab to
d70f712
Compare
lchrusciel
approved these changes
Aug 18, 2021
| Changes related to upgrade to GridBundle 1.10 | ||
| --------------------------------------------- | ||
|
|
||
| In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. |
Contributor
There was a problem hiding this comment.
Suggested change
| In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. | |
| Since the SyliusGridBundle v1.10, all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. |
Contributor
|
Thank you, Adam & Grzegorz! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Aug 18, 2021
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #12881 (review) | License | MIT Commits ------- eb121ac [Documentation] Minor fix in grids docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after merge PR Sylius/SyliusGridBundle#68 and release new version of
SyliusGridBundle