[API] [Catalog Promotion] validate action amount#13082
Merged
GSadee merged 1 commit intoSep 10, 2021
Merged
Conversation
Contributor
AdamKasp
commented
Sep 9, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
d31a892 to
b736937
Compare
arti0090
approved these changes
Sep 10, 2021
GSadee
reviewed
Sep 10, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
Add this case to the contract test: https://github.com/Sylius/Sylius/blob/master/tests/Api/Admin/CatalogPromotionsTest.php#L230
b736937 to
b20634e
Compare
GSadee
approved these changes
Sep 10, 2021
Member
|
Thanks, Adam! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.