Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[UI][Catalog Promotion] Add discounted product to cart#13103

Merged
GSadee merged 3 commits into
Sylius:masterfrom
AdamKasp:add-discounted-product-to-cart
Sep 15, 2021
Merged

[UI][Catalog Promotion] Add discounted product to cart#13103
GSadee merged 3 commits into
Sylius:masterfrom
AdamKasp:add-discounted-product-to-cart

Conversation

@AdamKasp
Copy link
Copy Markdown
Contributor

@AdamKasp AdamKasp commented Sep 14, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

Screenshot 2021-09-15 at 11 22 09

@AdamKasp AdamKasp added the API APIs related issues and PRs. label Sep 14, 2021
@AdamKasp AdamKasp requested a review from a team as a code owner September 14, 2021 13:45
@probot-autolabeler probot-autolabeler Bot added the Shop ShopBundle related issues and PRs. label Sep 14, 2021
@AdamKasp AdamKasp force-pushed the add-discounted-product-to-cart branch 3 times, most recently from 1bd5637 to 93133e4 Compare September 14, 2021 13:53
@AdamKasp AdamKasp force-pushed the add-discounted-product-to-cart branch from 93133e4 to bcd612c Compare September 14, 2021 18:42
Copy link
Copy Markdown
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an additional scenario to check the price of item in the cart when there is both a catalog and a cart promotion?

Comment thread src/Sylius/Bundle/ShopBundle/Resources/views/Cart/Summary/_item.html.twig Outdated
@AdamKasp AdamKasp force-pushed the add-discounted-product-to-cart branch from d4ec83b to 8e75159 Compare September 15, 2021 06:59
@AdamKasp AdamKasp force-pushed the add-discounted-product-to-cart branch from 8e75159 to 801a6b1 Compare September 15, 2021 07:50
@AdamKasp AdamKasp force-pushed the add-discounted-product-to-cart branch from 227a07c to 38904c8 Compare September 15, 2021 09:23
@GSadee GSadee merged commit 09998e1 into Sylius:master Sep 15, 2021
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Sep 15, 2021

Thank you, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Shop ShopBundle related issues and PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants