[API][CatalogPromotion] Reapplying catalog promotions on rule update#13129
Merged
Conversation
Contributor
SirDomin
commented
Sep 21, 2021
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
80cdd3a to
b2f86a2
Compare
GSadee
reviewed
Sep 22, 2021
Zales0123
reviewed
Sep 22, 2021
45ea582 to
1befd29
Compare
GSadee
reviewed
Sep 24, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
As we have the possibility to define more than one, I would be for adding another scenario for checking reapplying after adding a second rule to catalog promotion that already has one defined
454f1d0 to
f2fedce
Compare
lchrusciel
reviewed
Sep 27, 2021
| return $this->createQueryBuilder('o') | ||
| ->andWhere('o.originalPrice IS NOT NULL') | ||
| ->andWhere('o.originalPrice > o.price') | ||
| ->andWhere('o.appliedPromotions != \'[]\'') |
Contributor
There was a problem hiding this comment.
Are we sure, this notation will be the same for postgres?
Member
There was a problem hiding this comment.
As we don't have a build for postgres, I am not 100% sure
f2fedce to
c34c503
Compare
…ing catalog promotions after editing rules
c34c503 to
effb8eb
Compare
a261860 to
7194095
Compare
AdamKasp
approved these changes
Sep 29, 2021
| And the visitor should see that the "PHP Mug" variant is discounted from "$5.00" to "$2.50" with "Mug sale" promotion | ||
|
|
||
| @api | ||
| Scenario: Reapplying catalog promotion after adding another action |
Contributor
There was a problem hiding this comment.
Suggested change
| Scenario: Reapplying catalog promotion after adding another action | |
| Scenario: Reapplying catalog promotion after adding another rule |
Contributor
|
Thank you, Dominik and Grzegorz 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.