Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Fix admin path in swagger#13147

Merged
Zales0123 merged 1 commit into
Sylius:masterfrom
arti0090:fix-admin-route-in-swagger
Sep 28, 2021
Merged

[API] Fix admin path in swagger#13147
Zales0123 merged 1 commit into
Sylius:masterfrom
arti0090:fix-admin-route-in-swagger

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

@arti0090 arti0090 commented Sep 28, 2021

Q A
Branch? master
Bug fix? yes
New feature?
BC breaks? no
Deprecations? no
License MIT

The great comeback of admin authentication route 🎉
image
🎉

@arti0090 arti0090 requested a review from a team as a code owner September 28, 2021 09:02
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Sep 28, 2021
@arti0090 arti0090 added the Bug Confirmed bugs or bugfixes. label Sep 28, 2021
{
$docs = $this->decoratedNormalizer->normalize($object, $format, $context);
$paths = $docs['paths']->getArrayCopy();
$paths = (array) $docs['paths'];
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is a potential bugfix. If the decoration priority is set to different number, the $docs sometimes can be a normal array (not ArrayObject), in this case getArrayCopy() throws error, but (array) does the same and does not make any issue.

@Zales0123 Zales0123 merged commit 677855e into Sylius:master Sep 28, 2021
@Zales0123
Copy link
Copy Markdown
Contributor

Thank you, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants