[API] Do not allow to address empty cart#13154
Merged
Merged
Conversation
5c26959 to
724ac5b
Compare
arti0090
approved these changes
Sep 30, 2021
| And the visitor try to specify the incorrect billing address as "Ankh Morpork", "Frost Alley", "90210", "United Russia" for "Jon Snow" | ||
| And the visitor complete the addressing step | ||
| Then I should be notified that "United Russia" country does not exist | ||
| Then they should be notified that "United Russia" country does not exist |
Contributor
There was a problem hiding this comment.
Why they? When the context changed from singular to plural?
Contributor
Author
There was a problem hiding this comment.
It's singular they 💃 But in fact it should be "I" everywhere, as the feature is written from the Visitor's perspective
GSadee
approved these changes
Sep 30, 2021
Member
GSadee
left a comment
There was a problem hiding this comment.
But the steps in these scenarios should be refactored from the visitor to I perspective
Member
|
Thanks, Mateusz! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After addressing the empty cart and adding an item to it, there is a cart with some products but payment_skipped as payment state 💃 In theory, it's not a problem, as after completion payment state is correct (awaiting payment), but if anything happens about payment before checkout completion, it can lead to some nasty errors. And, conceptually, addressing empty cart does not seems as something correct 🚀