Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Architecture tests initialization #13426

Merged
GSadee merged 3 commits into
Sylius:1.10from
Zales0123:architecture-tests-initialization
Jan 3, 2022
Merged

Architecture tests initialization #13426
GSadee merged 3 commits into
Sylius:1.10from
Zales0123:architecture-tests-initialization

Conversation

@Zales0123
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

This is my first try to use PHPArkitect tool - but it seems promising! I believe with this library we could ensure some architectural conventions and proper dependencies. Let me know what you think about it 🖖 🚀 🏗️

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Dec 30, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner December 30, 2021 09:26
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Dec 30, 2021
Comment thread phparkitect.php
Comment thread .github/workflows/application.yml Outdated
@lchrusciel lchrusciel changed the base branch from 1.10 to 1.11 December 30, 2021 16:01
@lchrusciel lchrusciel changed the base branch from 1.11 to 1.10 January 3, 2022 08:17
@GSadee GSadee merged commit 45365d9 into Sylius:1.10 Jan 3, 2022
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Jan 3, 2022

Thank you, Mateusz! 🥇

@Zales0123 Zales0123 deleted the architecture-tests-initialization branch January 3, 2022 10:09
@pfazzi
Copy link
Copy Markdown
Contributor

pfazzi commented Jan 4, 2022

Happy to see you started using PHPArkitect! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants