[Catalog Promotion] Improve fixtures#13608
Merged
Zales0123 merged 2 commits intoFeb 9, 2022
Merged
Conversation
Contributor
AdamKasp
commented
Feb 7, 2022
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| License | MIT |
26ed51a to
ba96e5b
Compare
lchrusciel
approved these changes
Feb 7, 2022
Contributor
lchrusciel
left a comment
There was a problem hiding this comment.
Do we want functional tests for fixtures? For example executing example factories and checking if returned objects is properly created /cc @Sylius/core-team
ba96e5b to
6feaea0
Compare
6feaea0 to
18b0b24
Compare
GSadee
reviewed
Feb 8, 2022
8ff83d2 to
2a31704
Compare
SirDomin
approved these changes
Feb 8, 2022
Zales0123
reviewed
Feb 9, 2022
2a31704 to
0459d9e
Compare
0459d9e to
ebb6fb4
Compare
Zales0123
approved these changes
Feb 9, 2022
Contributor
|
Thanks, Adam! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.