From 05fe9bb9e2ce7cfd3035e049d22c50b9358b95dc Mon Sep 17 00:00:00 2001 From: Benni Mack Date: Tue, 22 Apr 2025 13:56:30 +0200 Subject: [PATCH 1/4] [TASK] Improve error message (#671) When a versioned record cannot be found, the DB table and the UID of the live record is now added to the message of the exception. --- .../Core/Functional/Framework/DataHandling/ActionService.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Core/Functional/Framework/DataHandling/ActionService.php b/Classes/Core/Functional/Framework/DataHandling/ActionService.php index e376435a..bb8fc716 100644 --- a/Classes/Core/Functional/Framework/DataHandling/ActionService.php +++ b/Classes/Core/Functional/Framework/DataHandling/ActionService.php @@ -428,7 +428,7 @@ public function publishRecords(array $tableLiveUids, bool $throwException = true $versionedUid = $this->getVersionedId($tableName, (int)$liveUid); if (empty($versionedUid)) { if ($throwException) { - throw new Exception('Versioned UID could not be determined', 1476049592); + throw new Exception('Versioned UID of ' . $tableName . ':' . $liveUid . ' could not be determined', 1476049592); } continue; } From 10f15b61bf451e47ae923d354b75279d9b16a500 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Tue, 12 Aug 2025 17:11:34 +0200 Subject: [PATCH 2/4] [TASK] Greenify phpstan (#677) --- Build/phpstan/phpstan-baseline.neon | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon index 461c373c..a39ba5db 100644 --- a/Build/phpstan/phpstan-baseline.neon +++ b/Build/phpstan/phpstan-baseline.neon @@ -3,7 +3,7 @@ parameters: - message: '#^Offset 0 on non\-empty\-list\ on left side of \?\? always exists and is not nullable\.$#' identifier: nullCoalesce.offset - count: 1 + count: 2 path: ../../Classes/Composer/ComposerPackageManager.php - From eb8b84e17ce368a50e7605bdee787c76161ef8d6 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Tue, 12 Aug 2025 17:14:10 +0200 Subject: [PATCH 3/4] [TASK] Remove nightly-6 workflow (#675) core v11 is EOL. --- .github/workflows/nightly-6.yml | 23 ----------------------- 1 file changed, 23 deletions(-) delete mode 100644 .github/workflows/nightly-6.yml diff --git a/.github/workflows/nightly-6.yml b/.github/workflows/nightly-6.yml deleted file mode 100644 index dadee170..00000000 --- a/.github/workflows/nightly-6.yml +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: "nightly-6" -on: - schedule: - - cron: '42 5 * * *' - workflow_dispatch: - -jobs: - nightly-7: - name: "dispatch-nightly-6" - runs-on: ubuntu-22.04 - permissions: write-all - steps: - - name: Checkout '6' - uses: actions/checkout@v4 - with: - ref: '6' - - - name: Execute 'ci.yml' on '6' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - gh workflow run ci.yml --ref 6 From 8e261f11a37eda6cf8a57f7b48fe63ff618f3145 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Tue, 12 Aug 2025 17:17:04 +0200 Subject: [PATCH 4/4] [TASK] Add PHP 8.5 to test matrix (#678) --- .github/workflows/ci.yml | 2 +- Build/Scripts/runTests.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f912807c..21f8d5f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - php: [ '8.2', '8.3', '8.4' ] + php: [ '8.2', '8.3', '8.4', '8.5' ] steps: - name: Checkout ${{ github.event_name == 'workflow_dispatch' && github.head_ref || '' }} diff --git a/Build/Scripts/runTests.sh b/Build/Scripts/runTests.sh index 48b168fd..c632fd39 100755 --- a/Build/Scripts/runTests.sh +++ b/Build/Scripts/runTests.sh @@ -44,6 +44,7 @@ Options: - 8.2 (default): use PHP 8.2 - 8.3: use PHP 8.3 - 8.4: use PHP 8.4 + - 8.5: use PHP 8.5 -x Only with -s cgl|unit @@ -114,7 +115,7 @@ while getopts ":b:s:p:hxn" OPT; do ;; p) PHP_VERSION=${OPTARG} - if ! [[ ${PHP_VERSION} =~ ^(8.2|8.3|8.4)$ ]]; then + if ! [[ ${PHP_VERSION} =~ ^(8.2|8.3|8.4|8.5)$ ]]; then INVALID_OPTIONS+=("${OPTARG}") fi ;;