Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(createServerFn): allow FormData union type #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtt-artis wants to merge 2 commits into
base: main
Choose a base branch
from
+58 −4
Open

feat(createServerFn): allow FormData union type #6541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb8d079
feat(createServerFn): allow FormData union type
Jan 28, 2026
ab4c683
fix(createServerFn): add regression test
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/start-client-core/src/createServerFn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,12 +468,17 @@ export type ValidateValidatorInput<
TMethod extends Method,
TInputValidator,
> = TMethod extends 'POST'
? ResolveValidatorInput<TInputValidator> extends FormData
? ResolveValidatorInput<TInputValidator>
: ValidateSerializable<
ResolveValidatorInput<TInputValidator>,
? Extract<ResolveValidatorInput<TInputValidator>, FormData> extends never
? ValidateSerializable<
Exclude<ResolveValidatorInput<TInputValidator>, FormData>,
RegisteredSerializableInput<TRegister>
>
:
| FormData
| ValidateSerializable<
Exclude<ResolveValidatorInput<TInputValidator>, FormData>,
RegisteredSerializableInput<TRegister>
>
: ValidateSerializable<
ResolveValidatorInput<TInputValidator>,
RegisteredSerializableInput<TRegister>
Expand Down
49 changes: 49 additions & 0 deletions packages/start-client-core/src/tests/createServerFn.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,3 +879,52 @@ test('createServerFn respects TsrSerializable', () => {
Promise<{ nested: { custom: MyCustomTypeSerializable } }>
>()
})

test('createServerFn POST with FormData union validator', () => {
const validator = createServerFn({ method: 'POST' }).inputValidator<
(input: FormData | { id: string }) => { id: 'string' }
>

expectTypeOf(validator)
.parameter(0)
.parameter(0)
.toEqualTypeOf<FormData | { id: string }>()
})

test('createServerFn GET cannot use FormData union validator', () => {
const validator = createServerFn({ method: 'GET' }).inputValidator<
(input: FormData | { id: string }) => { output: 'string' }
>

expectTypeOf(validator).parameter(0).parameter(0).toEqualTypeOf<
| {
append: 'Function is not serializable'
delete: 'Function is not serializable'
get: 'Function is not serializable'
getAll: 'Function is not serializable'
has: 'Function is not serializable'
set: 'Function is not serializable'
forEach: 'Function is not serializable'
entries: 'Function is not serializable'
keys: 'Function is not serializable'
values: 'Function is not serializable'
[Symbol.iterator]: 'Function is not serializable'
}
| {
id: string
}
>()
})

test('createServerFn POST rejects FormData union with non-serializable', () => {
const validator = createServerFn({ method: 'POST' }).inputValidator<
(input: FormData | { func: () => void }) => { output: 'string' }
>

expectTypeOf(validator).parameter(0).parameter(0).toEqualTypeOf<
| FormData
| {
func: 'Function is not serializable'
}
>()
})