Improve target dependency not found fatalError (yonaskolb#883)

jerrymarino · web-flow · commit 1e3f93a8593d · 2020-06-09T15:55:04.000+10:00
It's pretty tricky to find out how to fix it otherwise. Hitting this
often when using XcodeGen with XCHammer for Bazel Xcode projects.
XCHammer simply pulls in transitive targets, but users can filter out a
subset of targets based on paths. Both XCHammer and XcodeGen Yaml give
users flexibility for specify what targets are in their Xcode project,
so it's useful to give them a better validation error if they create
one.
diff --git a/Sources/XcodeGenKit/PBXProjGenerator.swift b/Sources/XcodeGenKit/PBXProjGenerator.swift
@@ -340,7 +340,7 @@ public class PBXProjGenerator {
 
     func generateTargetDependency(from: String, to target: String) -> PBXTargetDependency {
         guard let targetObject = targetObjects[target] ?? targetAggregateObjects[target] else {
-            fatalError("target not found")
+            fatalError("Target dependency not found: from ( \(from) ) to ( \(target) )")
         }
 
         let targetProxy = addObject(

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ public class PBXProjGenerator {`
`340`	`340`
`341`	`341`	`func generateTargetDependency(from: String, to target: String) -> PBXTargetDependency {`
`342`	`342`	`guard let targetObject = targetObjects[target] ?? targetAggregateObjects[target] else {`
`343`		`- fatalError("target not found")`
	`343`	`+ fatalError("Target dependency not found: from ( \(from) ) to ( \(target) )")`
`344`	`344`	`}`
`345`	`345`
`346`	`346`	`let targetProxy = addObject(`