Thanks to visit codestin.com
Credit goes to github.com

Skip to content

IfcPropertiesProcessor.getProperties is brokenΒ #324

@K1vs

Description

@K1vs

Describe the bug πŸ“

When i use IfcPropertiesProcessor.getProperties i get list with empty objects, instead of list of objects with properties.
I found root cause in getProperties implementation - missed await keywords;
image

Reproduction ▢️

https://github.com/ThatOpen/engine_components/blob/main/src/ifc/IfcPropertiesProcessor/index.ts

Steps to reproduce πŸ”’

  1. Prepare scene with IFC model.
  2. Create IfcPropertiesProcessor
  3. Use getProperties
  4. Expected - list of objects with properties. Actual - list of emty objects.

System Info πŸ’»

System:
    OS: Windows 11 10.0.22631
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700K
    Memory: 14.25 GB / 31.79 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.5 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.5.1 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Edge: Chromium (122.0.2365.80)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    openbim-components: ^1.4.4 => 1.4.15

Used Package Manager πŸ“¦

npm

Error Trace/Logs πŸ“ƒ

No response

Validations βœ…

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions