fix: [BIM Tiles] Error when removing streamed model from scene #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
development-ac
pushed a commit
to Active-Collective/ac_engine_components
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After streaming an IFC model into the scene, if we call remove(modelID) from the FragmentStreamLoader, an error will be thrown by the loader's GeometryCullerRenderer remove(modelID), because while the _geometry property has been cleared, the _foundGeometry property will still have some of the model's geometry. The error is thrown the next time the culler is updated.
Additional context
This PR is trying to fix [issue:#345]
There is probably a more thorough approach to fix this issue, but for my use case this worked as intended. I just wanted to at least give attention to this issue.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).