fix: mobile device orthographic camera zoom #558
Conversation
Fix the orthographic camera's zoom functionality on mobile devices that it was not working. Added camera-controls package to enable extended actions to Orthographic camera. Added some functionalities to the camera when setting up the projection in the example.ts file. Reviewed-by: Goulielmos Refs: ThatOpen#531
|
Hey @GoulielmosFloros! Hope you're fine and thanks for being involved in solving this issue. 💪 There is one thing, and that is the issue you are trying to solve could be better solved inside the library it-self and not just in the example. In other words, if you solve the bug in the library then you can be sure it will be solved for anyone using the component (including the documentation example you changed). The issue creator mentioned a possible solution that could work. In that case, you can try to follow his suggestions to see if it works! I reference a screenshot of what he suggests: Do you mind giving that a try to see if it works? Thanks a lot! |
|
Hi @HoyosJuan, oh sorry I thought we could also do it in the example.ts file! No worries, like you said I modified the code in the library and what the person suggested now works correctly for me. Please check it out and let me know :D! |
|
Awesome @GoulielmosFloros! Is merged now :) Thanks 💪 |
* fix: mobile device orthographic camera zoom Fix the orthographic camera's zoom functionality on mobile devices that it was not working. Added camera-controls package to enable extended actions to Orthographic camera. Added some functionalities to the camera when setting up the projection in the example.ts file. Reviewed-by: Goulielmos Refs: ThatOpen#531 * fix: Fixed the issue in the libraries (projection.ts) instead of the example.ts file.
Description
Fix the orthographic camera's zoom functionality on mobile devices that it was not working.
fix: #531
Added camera-controls package to enable extended actions to Orthographic camera. Added some functionalities to the camera when setting up the projection in the example.ts file.
Reviewed-by: Goulielmos
Refs: #531
Additional context
No
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).