Update keyFinder.js

winsonrich · web-flow · commit a93d5cfe671a · 2018-10-31T10:10:17.000+08:00
1. modified the identifiers and used the suitable identifiers for the variables
2. leave the loop when a key is match and found to increase the speed of searching in this stage of development
3. return the key number if founded, return 0 if found nothing
diff --git a/Ciphers/keyFinder.js b/Ciphers/keyFinder.js
@@ -5,11 +5,9 @@ Note: This is a draft version, please help to modify, Thanks!
 function keyFinder(str){ // str is used to get the input of encrypted string
 	const wordbank =["is","Is","am","Am","are","Are","have","Have","has","Has","may","May","be","Be"];
 	let key = 0; // return zero means the key can not be found
- 	//var shiftNum = 0; //count the number of key shifted
 	let inStr = str.toString(); //convert the input to String
 	let outStr = ""; // store the output value
 	let wordInOutStr = ""; // temporary store the word inside the outStr, it is used for comparison
- 	//document.getElementById("debug").innerHTML = shiftNum; // debug: display the shifted number(s) 
  	for (let i=0; i<(52); i++){ //try the number of key shifted, the sum of character from a-z and A-Z is 26*2=52
 		outStr = caesarCipherEncodeAndDecodeEngine(inStr,i); // use the encrytpion engine to decrypt the input string, shiftNum=i
 		for ( let i=0; i<wordbank.length; i++){
@@ -20,9 +18,9 @@ function keyFinder(str){ // str is used to get the input of encrypted string
 			// this part need to be optimize with the calculation of the number of occurance of word's probabilities
 			// linked list will be used in the next stage of development to calculate the number of occurace of the key
 			if (wordbank[i] == wordInOutStr){
-        			return key=i;
+        			return key=i; // return the key number if founded
 			}
 		}
 	}
-	return key;
+	return 0; // return 0 if found nothing
 }

Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,9 @@ Note: This is a draft version, please help to modify, Thanks!`
`5`	`5`	`function keyFinder(str){ // str is used to get the input of encrypted string`
`6`	`6`	`const wordbank =["is","Is","am","Am","are","Are","have","Have","has","Has","may","May","be","Be"];`
`7`	`7`	`let key = 0; // return zero means the key can not be found`
`8`		`- //var shiftNum = 0; //count the number of key shifted`
`9`	`8`	`let inStr = str.toString(); //convert the input to String`
`10`	`9`	`let outStr = ""; // store the output value`
`11`	`10`	`let wordInOutStr = ""; // temporary store the word inside the outStr, it is used for comparison`
`12`		`- //document.getElementById("debug").innerHTML = shiftNum; // debug: display the shifted number(s)`
`13`	`11`	`for (let i=0; i<(52); i++){ //try the number of key shifted, the sum of character from a-z and A-Z is 26*2=52`
`14`	`12`	`outStr = caesarCipherEncodeAndDecodeEngine(inStr,i); // use the encrytpion engine to decrypt the input string, shiftNum=i`
`15`	`13`	`for ( let i=0; i<wordbank.length; i++){`
`@@ -20,9 +18,9 @@ function keyFinder(str){ // str is used to get the input of encrypted string`
`20`	`18`	`// this part need to be optimize with the calculation of the number of occurance of word's probabilities`
`21`	`19`	`// linked list will be used in the next stage of development to calculate the number of occurace of the key`
`22`	`20`	`if (wordbank[i] == wordInOutStr){`
`23`		`- return key=i;`
	`21`	`+ return key=i; // return the key number if founded`
`24`	`22`	`}`
`25`	`23`	`}`
`26`	`24`	`}`
`27`		`- return key;`
	`25`	`+ return 0; // return 0 if found nothing`
`28`	`26`	`}`