Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TransactionProcessing/CallbackHandler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: deepsource-autofix-e0c9e98b
Choose a base ref
...
head repository: TransactionProcessing/CallbackHandler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 12 commits
  • 9 files changed
  • 3 contributors

Commits on Sep 18, 2025

  1. Merge pull request #133 from TransactionProcessing/deepsource-autofix…

    …-e0c9e98b
    
    refactor: use file scoped namespaces
    StuartFerguson authored Sep 18, 2025
    Configuration menu
    Copy the full SHA
    66fdec1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2025

  1. refactor: use file scoped namespaces

    This PR modernizes the C# codebase by converting all traditional block-style namespace declarations to file-scoped namespace syntax. This change flattens the file structure, removes unnecessary indentation levels, and aligns the code with the latest C# conventions.
    
    - Use File Scoped `namespace`s instead of typical `namespace`s: Many source files originally declared block-scoped namespaces with braces, causing extra nesting and indentation. Each file has been updated to use the file-scoped namespace syntax (ending with a semicolon), and the `using` directives and class/record declarations have been moved to the top of the file. This refactor improves readability and consistency across the project.
    
    > This Autofix was generated by AI. Please review the change before merging.
    deepsource-autofix[bot] authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    cda200b View commit details
    Browse the repository at this point in the history
  2. :|

    StuartFerguson committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    4a3a5f1 View commit details
    Browse the repository at this point in the history
  3. refactor: simplify lambda when its body has a single statement

    This PR refactors lambda expressions that contain only a single statement to use more concise, expression-bodied forms and improves readability across chained calls.
    
    - Consider simplifying lambda when its body has a single statement: The original code used a block lambda for an async call and a tightly coupled Setup expression. In the first patch, the `Setup(a => a.GetLatestVersion(...))` call is reformatted across multiple lines for clarity while retaining its expression-bodied form. In the second patch, the multi-line block inside `Should.NotThrow(async () => { await ... })` is converted into an inline, expression-bodied async lambda, removing unnecessary braces and making the code more succinct.
    
    > This Autofix was generated by AI. Please review the change before merging.
    deepsource-autofix[bot] authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    5d6a824 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #134 from TransactionProcessing/deepsource-autofix…

    …-9ce2dbf5
    
    refactor: use file scoped namespaces
    StuartFerguson authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    332f413 View commit details
    Browse the repository at this point in the history
  5. refactor: rename DockerHelper subclass to CallbackHandlerDockerHelper

    This PR renames the child class to prevent name collisions with its parent class.
    - Child and parent classes cannot share the same name: The issue arose because the subclass "DockerHelper" shared the exact name with its base class, leading to ambiguity and compilation errors. We addressed this by renaming the subclass to "CallbackHandlerDockerHelper", clearly distinguishing it from the parent.
    
    > This Autofix was generated by AI. Please review the change before merging.
    deepsource-autofix[bot] authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    1c2dfd4 View commit details
    Browse the repository at this point in the history
  6. fix build issues

    StuartFerguson committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    585b643 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #135 from TransactionProcessing/deepsource-autofix…

    …-4a8f08f9
    
    refactor: rename DockerHelper subclass to CallbackHandlerDockerHelper
    StuartFerguson authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    e9bc017 View commit details
    Browse the repository at this point in the history
  8. refactor: enforce one public class per namespace

    This PR refactors the code to comply with the guideline of having a single public class per namespace. It removes an unintended BOM character, standardizes brace placement, and adds missing closing braces to properly scope classes within their namespaces.
    
    - Consider having 1 `public` class per namespace: DeepSource flagged that having multiple public classes in a single namespace can lead to tangled code organization and lower maintainability. The patch removes a hidden BOM character in the using directive that was causing inconsistent file encoding. It also standardizes opening brace placement and adds missing closing braces to ensure each public class is scoped within its own namespace.
    
    > This Autofix was generated by AI. Please review the change before merging.
    deepsource-autofix[bot] authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    eff51be View commit details
    Browse the repository at this point in the history
  9. refactor: declare classes and structs within a namespace

    This PR reorganizes the code by encapsulating all classes within the `CallbackHandler.IntegrationTests.Common` namespace, aligning with C# best practices and improving code maintainability and scope management.
    
    - Classes and structs should be declared within a `namespace`: DeepSource flagged that several classes (`GenericSteps`, `TestingContext`, `Setup`) were declared at the file root without a namespace. We introduced the `CallbackHandler.IntegrationTests.Common` namespace and wrapped these class definitions inside it, updating indentation and braces to ensure proper encapsulation and readability.
    
    > This Autofix was generated by AI. Please review the change before merging.
    deepsource-autofix[bot] authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    ccb78d8 View commit details
    Browse the repository at this point in the history
  10. :|

    StuartFerguson committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    da9f6f7 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #136 from TransactionProcessing/deepsource-autofix…

    …-cd47f680
    
    refactor: enforce one public class per namespace
    StuartFerguson authored Sep 19, 2025
    Configuration menu
    Copy the full SHA
    492f425 View commit details
    Browse the repository at this point in the history
Loading