From 13b7c295eae7e23e182ae635305e34eb17eed8cc Mon Sep 17 00:00:00 2001 From: Monkey Do Date: Fri, 11 Dec 2020 11:06:16 +0100 Subject: [PATCH 1/3] docs: update babel-loader example webpack config (#549) Set mode to 'write-references' as recommended in readme --- examples/babel-loader/webpack.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/babel-loader/webpack.config.js b/examples/babel-loader/webpack.config.js index 0acc9ae1..ac5f2803 100644 --- a/examples/babel-loader/webpack.config.js +++ b/examples/babel-loader/webpack.config.js @@ -22,6 +22,7 @@ module.exports = { semantic: true, syntactic: true, }, + mode: "write-references", }, }), ], From db5a181093f4c1f0d9d83762febe27ecd52b1362 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 11 Dec 2020 11:06:46 +0100 Subject: [PATCH 2/3] chore(deps): bump ini from 1.3.5 to 1.3.7 (#550) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index 69506a0a..31c2335b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4524,9 +4524,9 @@ inherits@2.0.3: resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de" ini@^1.3.4, ini@^1.3.5, ini@~1.3.0: - version "1.3.5" - resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927" - integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw== + version "1.3.7" + resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.7.tgz#a09363e1911972ea16d7a8851005d84cf09a9a84" + integrity sha512-iKpRpXP+CrP2jyrxvg1kMUpXDyRUFDWurxbnVT1vQPx+Wz9uCYsMIqYuSBLV+PAaZG/d7kRLKRFc9oDMsH+mFQ== init-package-json@^1.10.3: version "1.10.3" From 2a1348d463190b3a75090aa427e64a5ab53f909d Mon Sep 17 00:00:00 2001 From: Paul Rosania Date: Tue, 15 Dec 2020 01:16:06 -0800 Subject: [PATCH 3/3] fix: only invoke WDS tap when there are issues (#547) `webpack-dev-server` always performs a hot reload when its `sync` tap runs. As a result, `fork-ts-checker-webpack-plugin` triggers a hot reload upon completion in `async` mode even when no issues are reported. This commit adds a check for issues before invoking `webpack-dev-server`'s `sync` tap, which eliminates the unneeded reload. --- src/hooks/tapDoneToAsyncGetIssues.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/hooks/tapDoneToAsyncGetIssues.ts b/src/hooks/tapDoneToAsyncGetIssues.ts index 0f9dabe8..de0e6862 100644 --- a/src/hooks/tapDoneToAsyncGetIssues.ts +++ b/src/hooks/tapDoneToAsyncGetIssues.ts @@ -67,7 +67,9 @@ function tapDoneToAsyncGetIssues( configuration.logger.issues.log(chalk.green('No issues found.')); } - if (state.webpackDevServerDoneTap) { + // report issues to webpack-dev-server, if it's listening + // skip reporting if there are no issues, to avoid an extra hot reload + if (issues.length && state.webpackDevServerDoneTap) { issues.forEach((issue) => { const error = new IssueWebpackError(configuration.formatter(issue), issue);