Improved logging during setup (actions#113)

konradpabjan · brcrista · web-flow · commit 7a69c2bc7dc3 · 2020-07-15T19:13:43.000+02:00
* Improved error output during setup

* Change from debug to info for normal output

* Apply suggestions from code review

Co-authored-by: Brian Cristante &lt;33549821+brcrista@users.noreply.github.com&gt;

Co-authored-by: Brian Cristante &lt;33549821+brcrista@users.noreply.github.com&gt;
diff --git a/README.md b/README.md
@@ -136,7 +136,9 @@ You should specify only a major and minor version if you are okay with the most
 
 # Using `setup-python` with a self hosted runner
 
-If you would like to use `setup-python` and a self-hosted runner, there are a few extra things you need to make sure are set up so that new versions of Python can be downloaded and configured on your runner.
+Python distributions are only available for the same [environments](https://github.com/actions/virtual-environments#available-environments) that GitHub Actions hosted environments are available for. If you are using an unsupported version of Ubuntu such as `19.04` or another Linux distribution such as Fedora, `setup-python` will not work. If you have a supported self-hosted runner and you would like to use `setup-python`, there are a few extra things you need to make sure are set up so that new versions of Python can be downloaded and configured on your runner.
+
+If you are experiencing problems while configuring Python on your self-hosted runner, turn on [step debugging](https://github.com/actions/toolkit/blob/main/docs/action-debugging.md#step-debug-logs) to see addition logs.
 
 ### Windows
 
diff --git a/dist/index.js b/dist/index.js
@@ -6355,7 +6355,10 @@ function installPython(workingDirectory) {
             silent: true,
             listeners: {
                 stdout: (data) => {
-                    core.debug(data.toString().trim());
+                    core.info(data.toString().trim());
+                },
+                stderr: (data) => {
+                    core.error(data.toString().trim());
                 }
             }
         };
diff --git a/src/install-python.ts b/src/install-python.ts
@@ -3,6 +3,7 @@ import * as core from '@actions/core';
 import * as tc from '@actions/tool-cache';
 import * as exec from '@actions/exec';
 import {ExecOptions} from '@actions/exec/lib/interfaces';
+import {stderr} from 'process';
 
 const TOKEN = core.getInput('token');
 const AUTH = !TOKEN || isGhes() ? undefined : `token ${TOKEN}`;
@@ -37,7 +38,10 @@ async function installPython(workingDirectory: string) {
     silent: true,
     listeners: {
       stdout: (data: Buffer) => {
-        core.debug(data.toString().trim());
+        core.info(data.toString().trim());
+      },
+      stderr: (data: Buffer) => {
+        core.error(data.toString().trim());
       }
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -6355,7 +6355,10 @@ function installPython(workingDirectory) {`
`6355`	`6355`	`silent: true,`
`6356`	`6356`	`listeners: {`
`6357`	`6357`	`stdout: (data) => {`
`6358`		`- core.debug(data.toString().trim());`
	`6358`	`+ core.info(data.toString().trim());`
	`6359`	`+ },`
	`6360`	`+ stderr: (data) => {`
	`6361`	`+ core.error(data.toString().trim());`
`6359`	`6362`	`}`
`6360`	`6363`	`}`
`6361`	`6364`	`};`