|
1 | 1 | # How to hand in the weekly assignment |
2 | 2 |
|
3 | | -In this module you'll submit your assignment only using GIT and GitHub. |
| 3 | +In this module you'll submit your assignment only using GIT and GitHub. |
4 | 4 |
|
5 | 5 | 1. [GitHub](https://www.github.com/HackYourFuture/JavaScript) |
6 | 6 |
|
7 | | -## 1. GitHub assignment guide |
| 7 | +## 1. GitHub Assignment Guide |
8 | 8 |
|
9 | 9 | <a href="http://www.youtube.com/watch?feature=player_embedded&v=CpYARPYGQU8" target="_blank"><img src="./assets/submit-homework.png" width="400" height="250" alt="HYF Video" /></a> |
10 | 10 |
|
11 | 11 | Watch the video (by clicking the image) or go through the following walk-through to learn how to submit your assignment: |
12 | 12 |
|
13 | | -ONE TIME ONLY (START OF EVERY MODULE) |
| 13 | +### 1.1 One Time Only (start of every module) |
14 | 14 |
|
15 | 15 | 1. Create a [fork](https://help.github.com/en/articles/fork-a-repo) of the assignment module repository. For JavaScript (as well as the next 2 modules), the assignment module repository is `https://www.github.com/HackYourAssignment/Assignment-cohortXX` where XX is your cohort number. You do this by using the `fork` option on the top right. |
16 | 16 | 2. Navigate to the URL of the cloned repository (it should be in your personal GitHub account, under "repositories"). |
17 | | -3. Clone the repository, using SSH¹, to your local machine. You can do this by typing in `git clone <git url>` in the command line. |
| 17 | +3. Clone the repository, using SSH<sup>[1]</sup>, to your local machine. You can do this by typing in `git clone <git url>` in the command line. |
18 | 18 | 4. On your local machine, navigate to the folder using the command line. |
19 | 19 | 5. Make sure you've cloned it correctly by running `git status` from the command line. |
20 | 20 | 6. This assignment repository is a little special, have a look through the README how it all works! |
21 | 21 |
|
22 | | -EVERY WEEK |
| 22 | +### 1.2 Every Week |
23 | 23 |
|
24 | | -1. Do a `git pull` on your main branch to get the latest version. |
25 | | -2. Create a new branch for each week you have assignment. For example, for the assignment week 3² for JavaScript create a branch called `YOUR_NAME-w3-JavaScript`. Don't forget to checkout this branch after creating it. You should not modify the `main` branch. |
| 24 | +1. First make sure that you are in your `main` branch. If not, check it out first. |
| 25 | +2. With your `main` branch checked out, create a new branch to work on the assignments of the new week. For example, for the assignment week 3<sup>[2]</sup> for JavaScript create a branch called `YOUR_NAME-w3-JavaScript`. Don't forget to checkout this branch after creating it. Note that you should never modify the `main` branch. |
26 | 26 | 3. Make your assignment! |
27 | 27 | 4. Once you're finished, add your assignment to a commit. There will be some test and config files added by the test runner, this is expected and should be added! |
28 | 28 | 5. Create the commit (`git commit`). Make the commit message meaningful, for example `Finished project for assignment week 3`. |
29 | 29 | 6. Push the branch to your forked repository. |
30 | 30 | 7. On the GitHub page of your forked repository, click on the `create pull request` button. Make sure the `base repository` is the `Assignment-cohortXX` repository, on branch `main`. |
31 | | -8. Give the pull request a title in the following format: |
32 | | - |
33 | | -```markdown |
34 | | -Assignment week 3 <Your name> |
35 | | -``` |
36 | | - |
37 | | -9. Submit the pull request from your forked repository branch into the `main` branch. |
| 31 | +8. Give the pull request a title in the same format as you used for the branch, e.g: `YOUR_NAME-w3-JavaScript`. |
| 32 | +9. Submit the pull request from your forked repository branch into the `main` branch of the destination repository. |
38 | 33 |
|
39 | 34 | If you have any questions or if something is not entirely clear ¯\\\_(ツ)\_/¯, please ask/comment on Slack! |
40 | 35 |
|
41 | | -Notes: |
| 36 | +**Notes:** |
| 37 | + |
| 38 | +<small> |
| 39 | +[1] If you are in an AZC you may need to use HTTPS instead as the AZC may have blocked the network protocol used by SSH.<br> |
| 40 | +[2] This first week for which you need to submit an assignment is week 2 of the JavaScript module. |
42 | 41 |
|
43 | | -1. If you are in an AZC you may need to use HTTPS instead as the AZC may have blocked the network protocol used by SSH. |
44 | | -2. This first week for which you need to submit assignment is week 3 of the JavaScript module. |
| 42 | +</small> |
45 | 43 |
|
46 | 44 | # Assignments Review Process |
47 | 45 |
|
48 | 46 | ## Before you start |
| 47 | + |
49 | 48 | 1. You get assigned a mentor at the start of the module in the slack group chat. (S)He is responsible for reviewing your work for the duration of the module. |
50 | | -3. Please don't hesitate to contact Joséphine or the cohort supervisor if you are facing any issues. We are here to help you out! |
| 49 | +2. Please don't hesitate to contact your mentor or the education director if you are facing any issues. We are here to help you out! |
51 | 50 |
|
52 | 51 | ## Review process |
| 52 | + |
53 | 53 | Together with the mentor and other trainees in your group you have the freedom to decide on the way of communication. You can do video calls or get feedback via comments to the PR. |
54 | 54 |
|
55 | 55 | The mentor will start a group message on Slack and agree together on the way of communication. There, the mentor can keep the whole group informed of his/her availability and updates. |
56 | 56 |
|
57 | | - |
58 | 57 | ### Video calls |
59 | | -If your group chooses to do video calls, there're 2 options. Individual calls or a group call. |
60 | 58 |
|
61 | | -Please write down some questions before te start of the call. During the call it is important to make notes of the feedback from the mentor, so you know what has to be adjusted afterwards. |
| 59 | +If your group chooses to do video calls, there're 2 options. Individual calls or a group call. |
| 60 | + |
| 61 | +Please write down some questions before te start of the call. During the call it is important to make notes of the feedback from the mentor, so you know what has to be adjusted afterwards. |
62 | 62 |
|
63 | 63 | ### Comments to the PR |
| 64 | + |
64 | 65 | The mentor will place comments on your pull request. You have to adjust your work accordingly and reply on the feedback. |
65 | 66 |
|
66 | 67 | ### Timeline feedback |
67 | | -| Days | Activities | |
68 | | -| --- | --- | |
69 | | -|Tuesday (week 1) | Deadline for you to hand in your first version | |
70 | | -|Wednesday (week 1) - Tuesday (week 2) | Mentor provides feedback | |
71 | | -| Wednesday (week 2) - Tuesday (week 3) | you improve the assignment based on the feedback and mentor evaluates improvements | |
72 | | -| Wednesday (week 3) | Core-team member Assignment Approval Check. At this point every PR needs to be approved. | |
73 | 68 |
|
74 | | -It can happen that your mentor doesn't reply on your questions or your updated assignment. Please send a reminder via slack. If that doesn't work and you're afraid you can't make the deadline, contact your cohort supervisor. |
| 69 | +| Days | Activities | |
| 70 | +| ------------------------------------- | ---------------------------------------------------------------------------------------- | |
| 71 | +| Tuesday (week 1) | Deadline for you to hand in your first version | |
| 72 | +| Wednesday (week 1) - Tuesday (week 2) | Mentor provides feedback | |
| 73 | +| Wednesday (week 2) - Tuesday (week 3) | you improve the assignment based on the feedback and mentor evaluates improvements | |
| 74 | +| Wednesday (week 3) | Core-team member Assignment Approval Check. At this point every PR needs to be approved. | |
| 75 | + |
| 76 | +It can happen that your mentor doesn't reply on your questions or your updated assignment. Please send a reminder via slack. If that doesn't work and you're afraid you can't make the deadline, contact your cohort supervisor. |
| 77 | + |
| 78 | +### Labels |
75 | 79 |
|
76 | | -### Labels |
77 | 80 | It is important for the you and the core-team to have up to date info about the status of the assignment. This is why the mentors use two labels on your PR. |
78 | 81 |
|
79 | | -| Label | Description | |
80 | | -| --- | --- | |
81 | | -|no label |not reviewed yet | |
82 | | -|Needs work |reviewed, but you need to implement feedback | |
83 | | -|Approved |reviewed, and your assignment has been approved | |
| 82 | +| Label | Description | |
| 83 | +| ---------- | ----------------------------------------------- | |
| 84 | +| no label | not reviewed yet | |
| 85 | +| Needs work | reviewed, but you need to implement feedback | |
| 86 | +| Approved | reviewed, and your assignment has been approved | |
84 | 87 |
|
85 | 88 | Here is an example of this in action. |
86 | 89 |
|
87 | 90 |  |
88 | | - |
|
0 commit comments