updated homework week4

mkruijt · mkruijt · commit b95c4cbeb670 · 2017-09-16T15:12:36.000+02:00
diff --git a/Week1/MAKEME.md b/Week1/MAKEME.md
@@ -68,17 +68,19 @@ For example:
 On freeCodeCamp.com please do the [Basic JavaScript](https://www.freecodecamp.com/challenges/learn-how-free-code-camp-works) exercises up and until the __"Shopping List"__ exercise (there are some topics we did not cover but you can do it).
 
 ### How to hand in Homework:
->steps:
-- Create a Github account
-- Create a new repository (name it something like hyf-javascript1) make sure you select the option: initialize with README
-- inside this repository create a folder "week1"
-- Upload the files you created on your computer inside the week1 folder, write a description for this “commit”
-- Open the file in your README to check if this all worked
-
->Create a new repository "hyf-javascript1". Also create a new folder "week1" inside this repository. 
-Upload your homework files inside the week1 folder and write a description for this “commit”.
-Your hyf-javascript1/week1 should now contain all your homework files.
-Place the link to your repository folder in Trello.
+```
+steps:
+• Create a Github account
+• Create a new repository (name it something like hyf-javascript1) make sure you select the option: initialize with README
+• inside this repository create a folder "week1"
+• Upload the files you created on your computer inside the week1 folder, write a description for this “commit”
+• Open the file in your README to check if this all worked
+
+• Create a new repository "hyf-javascript1". Also create a new folder "week1" inside this repository. 
+• Upload your homework files inside the week1 folder and write a description for this “commit”.
+• Your hyf-javascript1/week1 should now contain all your homework files.
+• Place the link to your repository folder in Trello.
+```
 
 ### Hint
 If you solve the FreeCodeCamp challenges and they are new concepts to you and you would like to take a look at them later on in the program, Copy your answers from FCC in a .js file and upload them to Github in a repository for future reference. In this way you build your own little documentation, if you look back at them first try to understand what it does before you run them.
diff --git a/Week2/MAKEME.md b/Week2/MAKEME.md
@@ -143,10 +143,13 @@ Please make sure you REALLY understand the exercises below:
 - https://www.freecodecamp.com/challenges/add-new-properties-to-a-javascript-object
 - https://www.freecodecamp.com/challenges/delete-properties-from-a-javascript-object
 
->Upload your homework in your "hyf-javascript1" Github repository. Make sure to create a new folder "week2" first. 
-Upload your homework files inside the week2 folder and write a description for this “commit”.
-Your hyf-javascript1/week2 should now contain all your homework files.
-Place the link to your repository folder in Trello.
+```
+How to hand in your homework:
+• Upload your homework in your "hyf-javascript1" Github repository. Make sure to create a new folder "week2" first. 
+• Upload your homework files inside the week2 folder and write a description for this “commit”.
+• Your hyf-javascript1/week2 should now contain all your homework files.
+• Place the link to your repository folder in Trello.
+```
 
 :star: Additional resources and review: [here](https://github.com/HackYourFuture/JavaScript/tree/master/Week2/REVIEW.md) (work in progress):star:
 
diff --git a/Week3/MAKEME.md b/Week3/MAKEME.md
@@ -34,10 +34,13 @@ Your Github should contain two repositories called hyf-javascript1 and hyf-comma
  
 7. Download book covers for each book, construct a new Object which has as keys the bookId's again, and as value the path to the image source (e.g. `{"harry_potter_blabla": "./img/harry_potter_blabla.jpg", ...}`). Now loop over these entries (_hint: `Object.keys(objectName)` gives you an array containing the keys_). Then write a function which places an image at the corresponding `li` element. Remember that Objects are not ordered, so you cannot guarantee that the first key is the first `li` element. (_Hint: you could give each `li` item an `id` tag by modifying the function you made before_)
 
->Upload your homework in your "hyf-javascript1" Github repository. Make sure to create a new folder "week3" first. 
-Upload your homework files inside the week3 folder and write a description for this “commit”.
-Your hyf-javascript1/week3 should now contain an index.html, main.css and a script.js file (and the images folder)
-Place the link to your repository folder in Trello.
+```
+How to hand in your homework:
+• Upload your homework in your "hyf-javascript1" Github repository. Make sure to create a new folder "week3" first. 
+• Upload your homework files inside the week3 folder and write a description for this “commit”.
+• Your hyf-javascript1/week3 should now contain an index.html, main.css and a script.js file (and the images folder)
+• Place the link to your repository folder in Trello.
+```
 
 ## Step 4: **FreeCodeCamp challenges:**
 
diff --git a/Week3/REVIEW.md b/Week3/REVIEW.md
@@ -214,7 +214,7 @@ document.getElementById("myH").innerHTML = "My First Page";
 
 Single line comments at end of the line:
 ```js
-var x = 5;      // Declare x, give it the value of 5
+const x = 5;      // Declare x, give it the value of 5
 ```
 
 Coding **well** in JavaScript: [JSDoc](http://usejsdoc.org/)
diff --git a/Week4/MAKEME.md b/Week4/MAKEME.md
@@ -2,14 +2,33 @@
 
 >[Here](https://github.com/HackYourFuture/JavaScript/tree/master/Week4/README.md) you find the readings you have to complete before the fourth lecture.
 
-## Step 1: Some Challenges:
+## Step 0: 
+Give yourself (or your neighbor) a little tap on the shoulder, you've made it to JS2! :muscle:
+
+## Step 1: Some Challenges
 - https://www.freecodecamp.com/challenges/using-objects-for-lookups
 - https://www.freecodecamp.com/challenges/manipulating-complex-objects
 - https://www.freecodecamp.com/challenges/convert-json-data-to-html
 
-## Step 2: Custom Challenge
+## Step 2: Custom challenge 
+1. Go to http://www.omdbapi.com/?s=dog and change the word dog in the url to a different common word. You will get as a result, a list of movies with this word in the title. Make sure you get at least 5 results.
+2. You can copy the JSON and put it in a string at the top of your js file. Print the title of the 3rd movie in the array to the console.
+3. Make a ul with a li for each title (just like you did with the books in the previous assignment
+4. Use CSS to divide the page in two columns. The left column will have a list of the titles for each movie. The right column will have all the information listed for each movie.
+5. Replace the "Poster" property with the actual image of the poster. If you do this correctly, in the right column there will be a picture for each movie.
+6. Use the imdbID to create an URL to the IMDB page for that movie (hint: IMDB urls always look like this http://www.imdb.com/title/[imdbId] where [imdbId] would be replaced by the actual Id. If you do this correctly, each movie will have a link to its own IMDB page. Make sure the link opens in a new tab
+
+## Step 3:
+
+Give one of you fellow students in Github feedback about their code of step two, create an issue in their repo, telling them what they did great and what they can improve.
+
+## Step 4: Almost there...
 
-In the HYF Movies Hands-On, we created the function `sortByImdbRating(movies)` to sort the list of movies by IMDB rating. Replace this function by a generalised version that takes the name of the property (`propName`) to sort on and a number `order` (allowed values 1 or -1, default value = 1) to indicate respectively ascending or descending sort order:
+Created a function `sortByImdbRating(movies)` to sort the list of movies by IMDB rating. 
+
+### :boom: Bonus homework :boom:
+
+Replace this function by a generalised version that takes the name of the property (`propName`) to sort on and a number `order` (allowed values 1 or -1, default value = 1) to indicate respectively ascending or descending sort order:
 
 ```
 function sortMovies(movies, propName, order)
@@ -31,8 +50,12 @@ Notes:
 1. Do not bother to make this work for the `Ratings` property which refers to an object rather than a simple value.
 2. It is not necessary to convert property values containing dates or numbers formatted with embedded commas to facilitate sorting for this challenge (but you're welcome to try). You can leave the value 'as is'.
 
->Create a new repository "hyf-javascript2". Also create a new folder "week1" inside this repository. 
-Upload your homework files inside the week1 folder and write a description for this “commit”.
-Your hyf-javascript2/week1 should now contain the files of your homework.
-Place the link to your repository folder in Trello.
+:octocat: 
+```
+How to hand in your homework:
+• Create a new repository "hyf-javascript2". Also create a new folder "week1" inside this repository. 
+• Upload your homework files inside the week1 folder and write a description for this “commit”.
+• Your hyf-javascript2/week1 should now contain the files of your homework.
+• Place the link to your repository folder in Trello.
+```
 
diff --git a/Week5/MAKEME.md b/Week5/MAKEME.md
@@ -22,7 +22,7 @@
 
    Look at the [documentation of the API](https://github.com/typicode/json-server) and see which other query parameters `json-server` support. Mess around with this to see how changing (or adding) parameters modifies your results.
 
-4. Use the code from your previous assignment to render the new results. If you have already displayed previous results make sure you clear them (hint: `someElement.removeChild(someChild)`). Make sure you style these results, use a style sheet for this! Also make sure you do not use javascript to construct static elements. This way you can handle the positioning of elements easier.
+4. Use the code from your previous assignment to render the new results. If you have already displayed previous results make sure you clear them (hint: `someElement.removeChild(someChild)`). Make sure you style these results, use a style sheet for this! Also make sure you do not use JavaScript to construct static elements. This way you can handle the positioning of elements easier.
 
 5. Change the layout of the page so that you only show a list of movie titles on the left side of your page. When the user hovers over a link (or maybe with a click) you want to show the additional information about the movie (poster, year etc.) on the right column. 
 
@@ -111,9 +111,11 @@ console.log(y);
 ```
 If you are confused please run the code and then consult the Google for "javascript pass by value pass by reference"
 
->Upload your homework in your "hyf-javascript2" Github repository. Make sure to create a new folder "week2" first. 
-Upload your homework files inside the week2 folder and write a description for this “commit”.
-Your hyf-javascript2/week2 should now contain all your homework files.
+```
+How to hand in your homework:
+• Upload your homework in your "hyf-javascript2" Github repository. Make sure to create a new folder "week2" first. 
+• Upload your homework files inside the week2 folder and write a description for this “commit”.
+• Your hyf-javascript2/week2 should now contain all your homework files.
 Place the link to your repository folder in Trello.
-
+```
 
diff --git a/Week6/MAKEME.md b/Week6/MAKEME.md
@@ -26,8 +26,10 @@ __Requirements__:
 6. Make sure that when a user goes to your app, your github account info is loaded. They can then use the search field to find info about other github accounts.
 7. BONUS: Look through the data that Github sends back to you on your first API call and think about what other info would be usefull. Add more functionalities to your app like showing how many people starred a repositories or showing the names of the people followed by the current user.
 
->Upload your homework in your "hyf-javascript2" Github repository. Make sure to create a new folder "week3" first. 
-Upload your homework files inside the week3 folder and write a description for this “commit”.
-Your hyf-javascript2/week3 should now contain an index.html, main.css and a script.js file (and the images folder)
-Place the link to your repository folder in Trello.
-
+```
+How to hand in your homework:
+• Upload your homework in your "hyf-javascript2" Github repository. Make sure to create a new folder "week3" first. 
+• Upload your homework files inside the week3 folder and write a description for this “commit”.
+• Your hyf-javascript2/week3 should now contain an index.html, main.css and a script.js file (and the images folder)
+• Place the link to your repository folder in Trello.
+```
