Centralize icon definitions and document a supported override strategy in ActiveAdmin v4 #8954
javierartero
started this conversation in
General
Replies: 1 comment 1 reply
-
|
Hi Javier, thank you. I'm not opposed to potential improvements depending on the approach. Just know upfront that I prefer SVG's inline (in HTML) as it's simpler and has several benefits. The CSS based SVG icons are necessary for form controls (e.g. drop down arrow). Both cases allow for customization. I can understand the value of having it be more centralized. If the new approach is better and covers my concerns, I would be open to it. How would your suggested approach work? I'd be curious to know more. Thanks. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi maintainers,
While integrating ActiveAdmin v4 in production projects, I’ve repeatedly needed to replace a small subset of default icons for branding and UX consistency.
In
4.0.0-beta21, icons are defined across inline SVG in ERB templates and SVG data URIs generated inplugin.jsviasvgToTinyDataUri. Replacing a single icon typically requires patching templates or overriding styles generated by plugin.js from app CSS, which can become brittle across upgrades.One possible direction would be to centralize icon definitions into a structured, token-based workflow that:
@themetokens and@utilityclassessvgToTinyDataUriin JSThe intent would not be to change visual behavior (light/dark, RTL, states), nor introduce runtime dependencies, but to:
I’ve experimented with a small proof of concept that extracts icons into a CSS token layer while preserving the current rendering behavior.
Before drafting a PR, I’d like to confirm whether this architectural direction aligns with the project’s goals.
Beta Was this translation helpful? Give feedback.
All reactions