feat(eslint-plugin): specify which method is unbound and added test case (typescript-eslint#6281)

cparros · web-flow · commit cf3ffdd49ace · 2022-12-30T16:18:39.000-05:00
* Unbound-method test case added and specified error location

* test case update
diff --git a/packages/eslint-plugin/src/rules/unbound-method.ts b/packages/eslint-plugin/src/rules/unbound-method.ts
@@ -241,7 +241,7 @@ export default util.createRule<Options, MessageIds>({
               }
 
               checkMethodAndReport(
-                node,
+                property.key,
                 initTypes.getProperty(property.key.name),
               );
             }
diff --git a/packages/eslint-plugin/tests/rules/unbound-method.test.ts b/packages/eslint-plugin/tests/rules/unbound-method.test.ts
@@ -590,5 +590,59 @@ class OtherClass extends BaseClass {
         },
       ],
     },
+    {
+      code: `
+const values = {
+  a() {},
+  b: () => {},
+};
+
+const { a, b } = values;
+      `,
+      errors: [
+        {
+          line: 7,
+          column: 9,
+          endColumn: 10,
+          messageId: 'unboundWithoutThisAnnotation',
+        },
+      ],
+    },
+    {
+      code: `
+const values = {
+  a() {},
+  b: () => {},
+};
+
+const { a: c } = values;
+      `,
+      errors: [
+        {
+          line: 7,
+          column: 9,
+          endColumn: 10,
+          messageId: 'unboundWithoutThisAnnotation',
+        },
+      ],
+    },
+    {
+      code: `
+const values = {
+  a() {},
+  b: () => {},
+};
+
+const { b, a } = values;
+      `,
+      errors: [
+        {
+          line: 7,
+          column: 12,
+          endColumn: 13,
+          messageId: 'unboundWithoutThisAnnotation',
+        },
+      ],
+    },
   ],
 });

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ export default util.createRule<Options, MessageIds>({`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`checkMethodAndReport(`
`244`		`- node,`
	`244`	`+ property.key,`
`245`	`245`	`initTypes.getProperty(property.key.name),`
`246`	`246`	`);`
`247`	`247`	`}`