Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Example names do not contain library name #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kattni opened this issue Jun 8, 2020 · 1 comment · Fixed by #19
Closed

Example names do not contain library name #17

kattni opened this issue Jun 8, 2020 · 1 comment · Fixed by #19
Assignees
@jimbobbennett

Comments

@kattni
Copy link
Contributor

kattni commented Jun 8, 2020

The Adafruit CircuitPython library standard is to include the library name in all example names. Every example is included on its own in the example bundle, and without the library name included, the bundle gets confusing and unusable.

@jimbobbennett You recently made changes to this library and its examples. Do you have any suggestions as to how best to include the library name azureiot_ in the example names? I notice you included iot in all of them, I would suggest that be updated to azureiot_, but I would like to hear your thoughts.
@jimbobbennett
Copy link
Collaborator

Apologies - I didn't realize that was the standard.

I've raised #19 to use azureiot_ as a prefix. The use of IoT was because the examples were for Azure IoT Central and Azure IoT Hub, so I wanted to include the service name that the example connects to. Having azureiot_central or azureiot_hub as a prefix works.

@jimbobbennett jimbobbennett linked a pull request Jun 8, 2020 that will close this issue
Renaming files to match example standard #19
Merged
@jimbobbennett jimbobbennett self-assigned this Jun 8, 2020
@kattni kattni closed this as completed in #19 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimbobbennett jimbobbennett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming files to match example standard jimbobbennett/Adafruit_CircuitPython_AzureIoT
2 participants
@jimbobbennett @kattni