Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allow changing fill and outline colors after initialization #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FoamyGuy opened this issue Jan 20, 2021 · 1 comment
Closed

allow changing fill and outline colors after initialization #25

FoamyGuy opened this issue Jan 20, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@FoamyGuy
Copy link

Currently the constructor is the only way to change fill_color and outline_color of a Button.

The underlying display_shapes objects do have fill and outline properties that allow them to be be changed any time after initialization.

It would be great to have properties and setters to the Button that allow user code to set those without having know about or mess with the underlying shapes objects.

I think it's a pretty natural assumption for users make to think the button would allow this, the issue was first noted on a forum post here: https://forums.adafruit.com/viewtopic.php?f=60&t=174113

@FoamyGuy FoamyGuy added enhancement New feature or request good first issue Good for newcomers labels Jan 20, 2021
@FoamyGuy
Copy link
Author

resolved by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant