From 239f8e31b8795bab2aa91d194ef53a4ec3f8d9eb Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Thu, 19 Jan 2023 23:39:55 -0500 Subject: [PATCH 1/4] Add upload url to release action Signed-off-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com> --- .github/workflows/release_gh.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release_gh.yml b/.github/workflows/release_gh.yml index b8aa8d6..9acec60 100644 --- a/.github/workflows/release_gh.yml +++ b/.github/workflows/release_gh.yml @@ -16,3 +16,4 @@ jobs: uses: adafruit/workflows-circuitpython-libs/release-gh@main with: github-token: ${{ secrets.GITHUB_TOKEN }} + upload-url: ${{ github.event.release.upload_url }} From 4a6b6dc2915128ff2ee63be8bd8ffba4359754a9 Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Tue, 9 May 2023 20:26:25 -0400 Subject: [PATCH 2/4] Update pre-commit hooks Signed-off-by: Tekktrik --- .pre-commit-config.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 0e5fccc..70ade69 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -4,21 +4,21 @@ repos: - repo: https://github.com/python/black - rev: 22.3.0 + rev: 23.3.0 hooks: - id: black - repo: https://github.com/fsfe/reuse-tool - rev: v0.14.0 + rev: v1.1.2 hooks: - id: reuse - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.2.0 + rev: v4.4.0 hooks: - id: check-yaml - id: end-of-file-fixer - id: trailing-whitespace - repo: https://github.com/pycqa/pylint - rev: v2.15.5 + rev: v2.17.4 hooks: - id: pylint name: pylint (library code) From bbb6e0e5fe88406e3aa362f7e50f65db0497c6ce Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Wed, 10 May 2023 22:32:55 -0400 Subject: [PATCH 3/4] Run pre-commit --- adafruit_fona/adafruit_fona_socket.py | 1 + 1 file changed, 1 insertion(+) diff --git a/adafruit_fona/adafruit_fona_socket.py b/adafruit_fona/adafruit_fona_socket.py index 041d626..7aa210b 100644 --- a/adafruit_fona/adafruit_fona_socket.py +++ b/adafruit_fona/adafruit_fona_socket.py @@ -55,6 +55,7 @@ def htons(x: int) -> int: # keep track of sockets we allocate SOCKETS = [] + # pylint: disable=too-many-arguments, unused-argument def getaddrinfo(host, port: int, family=0, socktype=0, proto=0, flags=0): """Translate the host/port argument into a sequence of 5-tuples that From fe1c1f85be84ec80677e68c6d671e52f58238130 Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Thu, 11 May 2023 08:23:49 -0400 Subject: [PATCH 4/4] Linted per pre-commit --- adafruit_fona/adafruit_fona_socket.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_fona/adafruit_fona_socket.py b/adafruit_fona/adafruit_fona_socket.py index 7aa210b..c20c518 100644 --- a/adafruit_fona/adafruit_fona_socket.py +++ b/adafruit_fona/adafruit_fona_socket.py @@ -231,7 +231,7 @@ def settimeout(self, value: int) -> None: :param int value: Socket read timeout, in seconds. """ if value < 0: - raise Exception("Timeout period should be non-negative.") + raise ValueError("Timeout period should be non-negative.") self._timeout = value def gettimeout(self) -> int: