From ba57e7a6e1e6f1133637e0b25eac065e7287abb6 Mon Sep 17 00:00:00 2001 From: Vin Minichino Date: Tue, 9 Aug 2022 13:04:58 -0400 Subject: [PATCH 1/3] broke out animate() logic to guarantee each item calls animate without short circuit --- adafruit_led_animation/group.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/adafruit_led_animation/group.py b/adafruit_led_animation/group.py index ba1111f..6bf6a4b 100644 --- a/adafruit_led_animation/group.py +++ b/adafruit_led_animation/group.py @@ -152,7 +152,12 @@ def animate(self, show=True): member.show() return result - return any(item.animate(show) for item in self._members) + ret=False + for item in self._members: + if item.animate(show): + ret=True + return ret + #return any(item.animate(show) for item in self._members) @property def color(self): From d02dde7622cee52dbffbd638a9a3f521de817e72 Mon Sep 17 00:00:00 2001 From: Vin Minichino Date: Tue, 9 Aug 2022 13:38:12 -0400 Subject: [PATCH 2/3] cleanup comments --- adafruit_led_animation/group.py | 1 - 1 file changed, 1 deletion(-) diff --git a/adafruit_led_animation/group.py b/adafruit_led_animation/group.py index 6bf6a4b..3a27d50 100644 --- a/adafruit_led_animation/group.py +++ b/adafruit_led_animation/group.py @@ -157,7 +157,6 @@ def animate(self, show=True): if item.animate(show): ret=True return ret - #return any(item.animate(show) for item in self._members) @property def color(self): From d9b877d8bac4e06f6a4ac405d67078482777781f Mon Sep 17 00:00:00 2001 From: Vin Minichino Date: Tue, 9 Aug 2022 15:33:56 -0400 Subject: [PATCH 3/3] blacked --- adafruit_led_animation/group.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adafruit_led_animation/group.py b/adafruit_led_animation/group.py index 3a27d50..97cdb1a 100644 --- a/adafruit_led_animation/group.py +++ b/adafruit_led_animation/group.py @@ -152,10 +152,10 @@ def animate(self, show=True): member.show() return result - ret=False + ret = False for item in self._members: if item.animate(show): - ret=True + ret = True return ret @property