Thanks to visit codestin.com
Credit goes to github.com

Skip to content

.side_set N opt is not currently implemented #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinjwalters opened this issue Mar 20, 2021 · 5 comments · Fixed by #27
Closed

.side_set N opt is not currently implemented #16

kevinjwalters opened this issue Mar 20, 2021 · 5 comments · Fixed by #27
Assignees
@tannewt

Comments

@kevinjwalters
Copy link

The optional opt flag for .side_set is not currently implemented in the assembler. This is used in some of the common PIO examples and an example in section 3.5.4 of the RP2040 data sheet.
@kevinjwalters
Copy link
Author

kevinjwalters commented Mar 20, 2021 •
edited
Loading

This may require additional code in the RP2040 CircuitPython code to distinguish between optional and non-optional side sets, cf https://github.com/micropython/micropython/blob/046164098337cc79dd0f6c710f49bdf6765aa711/ports/rp2/rp2_pio.c#L511-L522

@tannewt tannewt mentioned this issue Apr 7, 2021
Closed
@dannystaple
Copy link
Contributor

I just spent a few hours to find this again (with examples the same as #21) - including disassembling. Can we put a notice for this in https://circuitpython.readthedocs.io/en/latest/shared-bindings/rp2pio/index.html?#rp2pio.StateMac?

@tannewt
Copy link
Member

tannewt commented Dec 20, 2021

@dannystaple I don't think the CircuitPython doc should be updated for it because the issue is this library. I think it should work on the CP side. Instead, an error could be thrown by PIOASM if .side_set is in the assembly.

@tannewt tannewt self-assigned this Dec 21, 2021
@tannewt
Copy link
Member

tannewt commented Dec 21, 2021

I'm working on this now because it's needed for UART TX.

@dannystaple
Copy link
Contributor

Ah, that is even better. Let me know if you need a PR tested - I can give it a go.

tannewt added a commit to tannewt/Adafruit_CircuitPython_PIOASM that referenced this issue Dec 22, 2021
@tannewt
Add sideset assembly support.
9a1d5c6 
You must also set `sideset_enable` when creating the rp2pio.StateMachine
object.

Fixes adafruit#16 and fixes adafruit#21.
@tannewt tannewt mentioned this issue Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannewt tannewt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sideset assembly support. tannewt/Adafruit_CircuitPython_PIOASM
3 participants
@tannewt @dannystaple @kevinjwalters