adafruit_wiznet5k_socket.py has hardcoded 1000 second timeouts

Related, but separate, to #89 

There are at least two hardcoded timeouts for 1000:
https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k/blob/73bb5b6bfeb89f00fe90502ad4804b346a7d17f3/adafruit_wiznet5k/adafruit_wiznet5k_socket.py#L178-L189

I believe `time.monotonic()` returns [the number of seconds](https://github.com/adafruit/circuitpython/issues/1846#issuecomment-489667558). Waiting 1,000 seconds (over 16 minutes) in the `__exit__` block is _far_ too long.

	def __exit__(self, exc_type, exc_val, exc_tb) -> None:
	if self._sock_type == SOCK_STREAM:
	self.disconnect()
	stamp = time.monotonic()
	while self.status == wiznet5k.adafruit_wiznet5k.SNSR_SOCK_FIN_WAIT:
	if time.monotonic() - stamp > 1000:
	raise RuntimeError("Failed to disconnect socket")
	self.close()
	stamp = time.monotonic()
	while self.status != wiznet5k.adafruit_wiznet5k.SNSR_SOCK_CLOSED:
	if time.monotonic() - stamp > 1000:
	raise RuntimeError("Failed to close socket")

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adafruit_wiznet5k_socket.py has hardcoded 1000 second timeouts #90

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

adafruit_wiznet5k_socket.py has hardcoded 1000 second timeouts #90

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions